Repository navigation
Conversation
ktz03
marked this pull request as draft
November 9, 2026 03:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileStorageObserverblocks literal reserved filenames, butadd_artifact(..., name="./config.json")bypasses that comparison and overwrites the saved configuration without an observer error.Normalize the destination and the four protected paths to absolute, platform-case-normalized paths before comparing them. Keep the existing exception, copy destination, artifact registration and storage layout. Ordinary artifact replacement, including
nested/config.json, remains supported. Fixes #950.Validation on Windows AMD64 / CPython 3.11.16:
Experiment.run() -> Run.add_artifact()controls verify preserved configuration for rejected reserved aliases and successful ordinary copies/replacements.The full Sacred suite, tox/OS/Python matrix and pre-commit were not run locally. The reused environment satisfies runtime/dev requirements; its legacy
tests_requireconstraintmock<5is unmet by installed mock 5.2.0, which is not imported by the selected tests. No dependency changes were made.